Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize SDKActionModule #537

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Mar 8, 2023

Description

Improves on #520

  • Always initializes the SDKActionModule, handling internals with sensible (empty) defaults
  • Removes (no longer necessary) null checks and Nullable annotations
  • Addresses this comment by simply returning action not registered exception, removing separate exception handling for nulls.
  • BaseExtension no longer implements ActionExtension

Issues Resolved

Partial implementation of #525

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #537 (57f888d) into main (30759d2) will increase coverage by 0.15%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #537      +/-   ##
============================================
+ Coverage     67.67%   67.83%   +0.15%     
- Complexity      197      198       +1     
============================================
  Files            34       34              
  Lines           857      858       +1     
  Branches         29       26       -3     
============================================
+ Hits            580      582       +2     
- Misses          264      266       +2     
+ Partials         13       10       -3     
Impacted Files Coverage Δ
...rc/main/java/org/opensearch/sdk/BaseExtension.java 84.61% <ø> (ø)
...rch/sdk/sample/helloworld/HelloWorldExtension.java 66.66% <ø> (ø)
...main/java/org/opensearch/sdk/ExtensionsRunner.java 72.06% <100.00%> (+0.32%) ⬆️
src/main/java/org/opensearch/sdk/SDKClient.java 90.90% <100.00%> (-2.12%) ⬇️
...ava/org/opensearch/sdk/action/SDKActionModule.java 91.66% <100.00%> (+1.34%) ⬆️
...rch/sdk/handlers/ExtensionsInitRequestHandler.java 100.00% <100.00%> (+4.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saratvemulapalli saratvemulapalli merged commit 860c72e into opensearch-project:main Mar 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2023
Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 860c72e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Mar 9, 2023
(cherry picked from commit 860c72e)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 16, 2023
Kuanysh-kst pushed a commit to Kuanysh-kst/opensearch-sdk-java that referenced this pull request Mar 18, 2023
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants