-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always initialize SDKActionModule #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
March 8, 2023 00:35
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #537 +/- ##
============================================
+ Coverage 67.67% 67.83% +0.15%
- Complexity 197 198 +1
============================================
Files 34 34
Lines 857 858 +1
Branches 29 26 -3
============================================
+ Hits 580 582 +2
- Misses 264 266 +2
+ Partials 13 10 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ryanbogan
approved these changes
Mar 8, 2023
saratvemulapalli
approved these changes
Mar 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 860c72e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 9, 2023
(cherry picked from commit 860c72e) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Nurym <[email protected]>
Kuanysh-kst
pushed a commit
to Kuanysh-kst/opensearch-sdk-java
that referenced
this pull request
Mar 18, 2023
Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Kuanysh <[email protected]>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 19, 2023
Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Nurym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves on #520
SDKActionModule
, handling internals with sensible (empty) defaultsBaseExtension
no longerimplements ActionExtension
Issues Resolved
Partial implementation of #525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.