Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additional information in contributing document to require at l… #26

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

joshpalis
Copy link
Member

…east two pr approvals. Also linked the contributing doc to the developer guide

Signed-off-by: Joshua Palis [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…east two pr approvals. Also linked the contributing doc to the developer guide

Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis requested a review from a team June 22, 2022 22:36
@joshpalis joshpalis requested a review from ryanbogan June 22, 2022 23:46
@joshpalis joshpalis requested review from owaiskazi19 and ryanbogan and removed request for ryanbogan June 22, 2022 23:49
Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @joshpalis

@owaiskazi19 owaiskazi19 merged commit e38ac94 into opensearch-project:main Jun 27, 2022
@joshpalis joshpalis deleted the dev-guide branch June 28, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants