Move extension settings reading into the BaseExtension #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
=========================================
Coverage 65.86% 65.86%
Complexity 103 103
=========================================
Files 25 25
Lines 501 501
Branches 17 17
=========================================
Hits 330 330
Misses 159 159
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dbwiddis
requested changes
Oct 28, 2022
dbwiddis
requested changes
Oct 31, 2022
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Outdated
Show resolved
Hide resolved
Thank you for you comment @dbwiddis |
mloufra
force-pushed
the
moveextensionsetting
branch
from
2c4311a to
b71a1b5
Compare
owaiskazi19
previously approved these changes
Nov 2, 2022
dbwiddis
previously approved these changes
Nov 2, 2022
There was a problem hiding this comment.
LGTM! Great job, I think this will really simplify the experience for users!
@owaiskazi19 FYI, once this is merged you may want to simplify the AD Extension constructor as well.
|
@dbwiddis can you resolve the comments if they look good to you? Also, let's hold merging this until we fix the build error |
Done. |
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
dbwiddis
force-pushed
the
moveextensionsetting
branch
from
b71a1b5 to
51a0e23
Compare
dbwiddis
approved these changes
Nov 4, 2022
owaiskazi19
approved these changes
Nov 4, 2022
|
@dbwiddis I'll let you merge this one based on the sequence to avoid merge conflicts |
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…oject#205) * move extensionSetting to BaseExtension Signed-off-by: mloufra <[email protected]> * address comment Signed-off-by: mloufra <[email protected]> * address comment Signed-off-by: mloufra <[email protected]> * fix spotless error Signed-off-by: mloufra <[email protected]> * fix setting initialization error Signed-off-by: mloufra <[email protected]> * add new constructor in BaseExtensions Signed-off-by: mloufra <[email protected]> Signed-off-by: mloufra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra [email protected]
Description
Move the
extensionSettingsfield and the initialization in the constructor and all the exception handling inHelloWorldExtensiontoBaseExtension.Issues Resolved
Fixes #182
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.