Parse JSON XContent in the RestHelloAction #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
6 tasks
dbwiddis
force-pushed
the
parseContent
branch
from
85ddfdb to
df37944
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
parseContent
branch
from
df37944 to
8834d17
Compare
owaiskazi19
previously approved these changes
Oct 13, 2022
dbwiddis
commented
Oct 13, 2022
src/main/java/org/opensearch/sdk/sample/helloworld/rest/RestHelloAction.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
owaiskazi19
approved these changes
Oct 13, 2022
joshpalis
approved these changes
Oct 13, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Parse JSON XContent in the RestHelloAction Signed-off-by: Daniel Widdis <[email protected]> * Autofix newline and whitespace issues with spotless Signed-off-by: Daniel Widdis <[email protected]> * Null check Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis [email protected]
Companion PR: opensearch-project/OpenSearch#4760
✅ Check passes locally.
Description
Demonstrates the use of the
ExtensionRestRequestobject'scontentParser()method in the sample extension.Issues Resolved
Fixes #178
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.