Add getSettings support for AD #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
6 tasks
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
owaiskazi19
previously approved these changes
Sep 19, 2022
joshpalis
previously approved these changes
Sep 19, 2022
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
dismissed stale reviews from joshpalis and owaiskazi19
via
aa3fb6e
owaiskazi19
approved these changes
Sep 19, 2022
joshpalis
approved these changes
Sep 19, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Change RegisterRestActionsResponse to ExtensionStringResponse Signed-off-by: Daniel Widdis <[email protected]> * Rename ExtensionResponseHandler to ExtensionBooleanResponseHandler Signed-off-by: Daniel Widdis <[email protected]> * Fix compiler warning on incorrect static modifier Signed-off-by: Daniel Widdis <[email protected]> * Send RegisterSettingsRequest to OpenSearch Signed-off-by: Daniel Widdis <[email protected]> * Fix javadoc warnings Signed-off-by: Daniel Widdis <[email protected]> * s/Setting/CustomSetting/g Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: opensearch-project/OpenSearch#4519
NOTE: Gradle Check is failing due to new classes on the Companion PR. Check completes locally when the other PR branch is published to Maven Local. Re-run check after merging the companion PR.
NOTE: Merging the compainion PR will break
mainon SDK project until this PR (or at least the first commit from it) is merged. Merge this PR shortly after merging the companion PR.Description
Registers custom Settings from an extension as dynamic settings in the Settings Module.
The pattern is similar to registering REST actions.
Recommend reviewers evaluate the commits separately to simplify review. Explanation follows:
RegisterRestActionsResponseand a response for the settings toExtensionStringResponse. Merging the companion PR will breakmain; this first commit fixes the rename.ExtensionStringResponseHandlerit made sense to rename the handler for the boolean response to align.staticmodifier in Add ActionListener onFailure to ExtensionsRunner #87 created compiler warnings for accessing static methods non-statically. I undid that change.Issues Resolved
Fixes #79
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.