Remove warnings #134
Merged
Remove warnings #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes for warnings removal. NamedWriteableRegistryAPI remove unused local variables remove unused imports SDKClient remove unused private attribute remove unsed imports TransportActions add missing diamond operators TestNamedWriteableRegistryAPI remove unused constructor There are still missing generic declaration on Class<> attributes and variables, which cannot be fixed only through sdk project, as they are used as method parameters from classes that do not belong to sdk project and would require changes on these classes as well. fix #130 Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>
dbwiddis
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Thanks for your contribution, @lucasfsvilela !
You're right that fixing the Class generics requires updating code on the main OpenSearch project. If you'd like to tackle that in another PR you can submit two PRs: one here and one to OpenSearch linking to the feature/extensions branch there.
saratvemulapalli
approved these changes
Sep 13, 2022
owaiskazi19
approved these changes
Sep 13, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
Minor changes for warnings removal. NamedWriteableRegistryAPI remove unused local variables remove unused imports SDKClient remove unused private attribute remove unsed imports TransportActions add missing diamond operators TestNamedWriteableRegistryAPI remove unused constructor There are still missing generic declaration on Class<> attributes and variables, which cannot be fixed only through sdk project, as they are used as method parameters from classes that do not belong to sdk project and would require changes on these classes as well. fix opensearch-project#130 Signed-off-by: Lucas Faria e Souza Vilela <[email protected]> Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes for warnings removal.
NamedWriteableRegistryAPI
remove unused local variables
remove unused imports
SDKClient
remove unused private attribute
remove unsed imports
TransportActions
add missing diamond operators
TestNamedWriteableRegistryAPI
remove unused constructor
There are still missing generic declaration on Class<> attributes and variables, which cannot be fixed only through sdk project, as they are used as method parameters from classes that do not belong to sdk project and would require changes on these classes as well.
Signed-off-by: Lucas Faria e Souza Vilela [email protected]
Description
This change remove warnings from code without affecting any functionality.
Issues Resolved
Fixes portions of #130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.