Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed RubyGems MFA Opt-in clause #199

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Sep 14, 2023

  • Added Gemspec to the gem package for convenience when testing local gem with bundler
  • Resolved open-ended dependencies for multi_json
  • Updated authors and email fields to be in line with other OpenSearch gems.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nhtruong nhtruong changed the title Removed RubyGems MFA Removed RubyGems MFA Opt-in clause Sep 14, 2023
@@ -66,5 +65,5 @@ Gem::Specification.new do |s|
s.required_ruby_version = '>= 2.5'

s.add_dependency 'faraday', '>= 1.0', '< 3'
s.add_dependency 'multi_json'
s.add_dependency 'multi_json', '~> 1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious, did you mean >= 1.0? They are at 1.15. There's no reason why a 2.x won't work when that comes out.

Copy link
Collaborator Author

@nhtruong nhtruong Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional because I didn't want 2.x breaking changes to affect us. But, I guess then some of our specs would fail as a result as we can handle this issue then. Going to update it per your suggestion so that users can use 2.x in their apps if they want to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, generally you lock down semver a minimum of what's known at the time of writing. Otherwise you end up with an impossible to resolve matrix for no reason.

dblock
dblock previously approved these changes Sep 15, 2023
Signed-off-by: Theo Truong <[email protected]>
@nhtruong nhtruong merged commit a7cb0fb into opensearch-project:main Sep 15, 2023
55 checks passed
@nhtruong nhtruong deleted the remove_rubygems_mfa branch September 15, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants