-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aws-*
dependencies from >= 0.10
to >= 0.53
#108
Conversation
Credential types were split from `aws-types` into `aws-credential-types` Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 42.28% 42.28%
=======================================
Files 50 50
Lines 28086 28086
=======================================
Hits 11877 11877
Misses 16209 16209
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
So is this a breaking change? |
Yeah unfortunately, as due to the nature of the api it pushes that higher dependency onto the consumer (if they're using awssigv4). But we could maybe handwave it into a minor bump due to aws-* being treated as unstable and it being unrealistic to major bump the client everytime they change something. However I am going to think a bit about how this is exposed to clients (and my comments on #96) to see if we could nicely wall it off further. |
Handwave it. |
@Xtansia I could not find sample code for SigV4 in the user guide. Am I missing something or does it have to be added? |
I have docs as part of #96, but we have more problems. |
@Xtansia with this upgrade I am getting the following:
|
@dblock Based on the error my best guess is either not having the [dependencies]
opensearch = { git = "https://github.com/opensearch-project/opensearch-rs.git", features = ["aws-auth"] }
aws-config = "0.53" |
Thanks, I solved it like so. |
Description
Bump
aws-*
dependencies from>= 0.10
to>= 0.53
Credential types were split from
aws-types
intoaws-credential-types
Issues Resolved
Resolves #106
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.