Abstract away service name #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
VachaShah,
dblock,
axeoman,
deztructor and
Shephalimittal
as code owners
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
fix/sigv4serverless
branch
from
53d174e to
412bf35
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
fix/sigv4serverless
branch
from
7659e5c to
575f864
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
dblock
reviewed
Jan 13, 2023
harshavamsi
force-pushed
the
fix/sigv4serverless
branch
from
c8c73cf to
5998f41
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
fix/sigv4serverless
branch
from
5998f41 to
79fa2d3
Compare
dblock
requested changes
Jan 17, 2023
There was a problem hiding this comment.
The change of deleting content-length seems hidden in here. I believe this is to support Serverless and managed alike. I believe this won't be necessary when serverless GAs, so maybe remove it from this PR and open another specifically for the serverless workaround?
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
fix/sigv4serverless
branch
from
23359ee to
603b8ba
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
dblock
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Description
Removes hard coded service name. Users can specify their own service name while signing requests for SigV4.
Issues Resolved
Closes #259
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.