Added timeout to available input query parameters #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
requested review from
a team,
axeoman and
deztructor
as code owners
|
Needs a unit test, please? |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
|
@dblock added. |
dblock
requested changes
Oct 3, 2022
There was a problem hiding this comment.
One more thing, it needs to be documented in user guide/README.
I realize we don't have this here, or at least it doesn't look like other clients that have a USERS_GUIDE? @VachaShah what are we to do for this one?
dblock
approved these changes
Oct 3, 2022
|
USER_GUIDE is the GETTING_STARTED guide. @harshavamsi If you are making the change to this guide in your PR, can you also rename it to USER_GUIDE? |
axeoman
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Description
Fixes the timeout query parameter to allow for not just
request_timeoutbut alsotimeoutlike the examples say.Issues Resolved
Fixes #209
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.