Adding bulk api docs to getting_started #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
requested review from
a team,
axeoman and
deztructor
as code owners
VachaShah
reviewed
Aug 18, 2022
.gitignore
Outdated
| @@ -142,3 +142,10 @@ cython_debug/ | |||
| test_opensearch/cover | |||
| test_opensearch/local.py | |||
| .ci/output | |||
|
|
|||
| # Local test file | |||
There was a problem hiding this comment.
Are these generated files or just something for your local testing?
There was a problem hiding this comment.
Yep, adding some local files for testing. These are just gitignored.
There was a problem hiding this comment.
No I meant since this is not part of repo, lets not add them here as they are for local testing.
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
dblock
reviewed
Aug 25, 2022
GETTING_STARTED.md
Outdated
| client.bulk(docs) | ||
|
|
||
|
|
||
| # Bulk index documents using the helper function |
There was a problem hiding this comment.
Consider breaking up the samples into sections with their own code blocks?
There was a problem hiding this comment.
@dblock separated the docs, wdyt?
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
dblock
approved these changes
Aug 26, 2022
VachaShah
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Description
Adds examples on how to use bulk api through client and helpers.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.