Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sphinx link #169

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Add sphinx link #169

merged 1 commit into from
Jun 9, 2022

Conversation

PhilipMay
Copy link
Contributor

Add link to the Sphinx API doc to the README.md.
Fixes #10

@PhilipMay PhilipMay requested review from a team, axeoman and deztructor as code owners June 2, 2022 13:38
@PhilipMay
Copy link
Contributor Author

@axeoman @deztructor
PR is ready to be merged.

axeoman
axeoman requested changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@axeoman axeoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition 👍
However, I would like to ask you to squash both commits into a single one and call it with a capital letter.

@PhilipMay
Add link to api doc
6aff6f0 
Signed-off-by: Philip May <[email protected]>
@PhilipMay
Copy link
Contributor Author

However, I would like to ask you to squash both commits into a single one and call it with a capital letter.

Done

VachaShah
VachaShah approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @PhilipMay for adding this!

@VachaShah VachaShah merged commit 3add044 into opensearch-project:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@axeoman axeoman axeoman approved these changes

@deztructor deztructor Awaiting requested review from deztructor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation
3 participants
@PhilipMay @axeoman @VachaShah