Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Reference - python docs please! #171

Closed
jtlz2 opened this issue Jun 9, 2022 · 11 comments
Closed

API Reference - python docs please! #171

jtlz2 opened this issue Jun 9, 2022 · 11 comments
Labels
enhancement New feature or request plugin support

Comments

@jtlz2
Copy link

jtlz2 commented Jun 9, 2022

Is your feature request related to a problem?

I am always frustrated because in spite of sample documentation online there is an absence of a python API reference and/or easy-to-find docstrings. I have to go digging into the code to figure out function signatures. It would really speed up development if you would be able to post this somewhere.

What solution would you like?
An online API reference on e.g. readthedocs.io

What alternatives have you considered?
Sample code on SO or on github, plus digging into the code (time consuming and difficult to interpret!).

Do you have any additional context?
Please advise if I am missing where this is. If it's there, please simply make it easier to find!

Many thanks!

@jtlz2 jtlz2 added enhancement New feature or request untriaged Need triage labels Jun 9, 2022
@jtlz2 jtlz2 changed the title API Reference - docs please! API Reference - python docs please! Jun 9, 2022
@VachaShah
Copy link
Collaborator

Hi @jtlz2, @PhilipMay recently added the Sphinx link https://opensearch-project.github.io/opensearch-py/. Hope that helps!

@jtlz2
Copy link
Author

jtlz2 commented Jun 10, 2022

@VachaShah @PhilipMay Thank you - that is 💯 what I needed! Please could you make it more prominent around the place? If you hadn't told me I don't think I'd have found it. Thanks again!

@PhilipMay
Copy link
Contributor

Please could you make it more prominent around the place?

@jtlz2 what exactly do you mean? Maybe you want to provide a PR?

@CameronNemo
Copy link

@PhilipMay on this page would be nice: https://opensearch.org/docs/latest/clients/python/ ; and perhaps in the README / PyPI.

@PhilipMay
Copy link
Contributor

@PhilipMay on this page would be nice: https://opensearch.org/docs/latest/clients/python/ ; and perhaps in the README / PyPI.

It is already part of the README and will automatically be part of the pypi page on next release.

About https://opensearch.org/docs/latest/clients/python/ I do not know.

@jspreddy
Copy link

jspreddy commented Sep 8, 2022

I am still having to dig through the code base to figure things out. The python API documentation here is not complete. It only contains docs for top level classes.

For example on this page: https://opensearch-project.github.io/opensearch-py/api-ref/client.html it says to use the attributes and that attributes are instances of classes. But those classes are not in the docs.

The instance has attributes cat, cluster, indices, ingest, nodes, snapshot and tasks that provide access to instances of CatClient, ClusterClient, IndicesClient, IngestClient, NodesClient, SnapshotClient and TasksClient respectively. This is the preferred (and only supported) way to get access to those classes and their methods.

None of these classes are available in the api reference page or on the index page.

@harshavamsi
Copy link
Collaborator

@jspreddy the docs need improvement. Would you be willing to contribute a PR for the ones you see lacking?

@jaydm26
Copy link
Contributor

jaydm26 commented Sep 19, 2022

@harshavamsi Happy to take this up, if no one has volunteered yet

@harshavamsi
Copy link
Collaborator

Hi @jaydm26, absolutely go for it. Thanks!

@jaydm26
Copy link
Contributor

jaydm26 commented Sep 23, 2022

Hey @harshavamsi, I have raised a PR #204

@wbeckler wbeckler added plugin support and removed untriaged Need triage labels Nov 3, 2022
@VachaShah
Copy link
Collaborator

Closing this issue since docs have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin support
Projects
None yet
Development

No branches or pull requests

8 participants