-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Reference - python docs please! #171
Comments
Hi @jtlz2, @PhilipMay recently added the Sphinx link https://opensearch-project.github.io/opensearch-py/. Hope that helps! |
@VachaShah @PhilipMay Thank you - that is 💯 what I needed! Please could you make it more prominent around the place? If you hadn't told me I don't think I'd have found it. Thanks again! |
@jtlz2 what exactly do you mean? Maybe you want to provide a PR? |
@PhilipMay on this page would be nice: https://opensearch.org/docs/latest/clients/python/ ; and perhaps in the README / PyPI. |
opensearch-project/opensearch-py#171 Signed-off-by: Cameron Nemo <[email protected]>
It is already part of the README and will automatically be part of the pypi page on next release. About https://opensearch.org/docs/latest/clients/python/ I do not know. |
I am still having to dig through the code base to figure things out. The python API documentation here is not complete. It only contains docs for top level classes. For example on this page: https://opensearch-project.github.io/opensearch-py/api-ref/client.html it says to use the attributes and that attributes are instances of classes. But those classes are not in the docs.
None of these classes are available in the api reference page or on the index page. |
@jspreddy the docs need improvement. Would you be willing to contribute a PR for the ones you see lacking? |
@harshavamsi Happy to take this up, if no one has volunteered yet |
Hi @jaydm26, absolutely go for it. Thanks! |
Hey @harshavamsi, I have raised a PR #204 |
Closing this issue since docs have been added. |
Is your feature request related to a problem?
I am always frustrated because in spite of sample documentation online there is an absence of a python API reference and/or easy-to-find docstrings. I have to go digging into the code to figure out function signatures. It would really speed up development if you would be able to post this somewhere.
What solution would you like?
An online API reference on e.g. readthedocs.io
What alternatives have you considered?
Sample code on SO or on github, plus digging into the code (time consuming and difficult to interpret!).
Do you have any additional context?
Please advise if I am missing where this is. If it's there, please simply make it easier to find!
Many thanks!
The text was updated successfully, but these errors were encountered: