#285: Add support for Model profile #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kalyanr <[email protected]>
…ch-py-ml into kalyan/model-profile Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
…ch-py-ml into kalyan/model-profile
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
|
@dhrubo-os , Made changes according to our discussion. Please let me know if I need to change anything |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 91.47% 91.53% +0.05%
==========================================
Files 41 42 +1
Lines 4365 4395 +30
==========================================
+ Hits 3993 4023 +30
Misses 372 372 ☔ View full report in Codecov by Sentry. |
dhrubo-os
reviewed
Dec 16, 2023
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
rawwar
requested review from
greaa-aws,
ylwu-amzn,
b4sjoo,
jngz-es and
rbhavna
as code owners
|
@dhrubo-os , updated the docstring. Ready for review |
dhrubo-os
reviewed
Dec 20, 2023
Signed-off-by: Kalyan <[email protected]>
dhrubo-os
approved these changes
Dec 26, 2023
|
@dhrubo-os , can this be merged or is there anything else needed to be done? |
rbhavna
approved these changes
Jan 3, 2024
|
@rawwar , looks good to me, merged your PR. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Model Profile API
Issues Resolved
Closes #285
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.