Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to pyproject #356

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bilal-aamer
Copy link

@bilal-aamer bilal-aamer commented Dec 13, 2023

Description

Aims to transition the project opensearch-py-ml from setup.py and setup.cfg to pyproject.toml of the PEP 621 standard

Issues Resolved

#308

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bilal-aamer <[email protected]>
@rawwar
Copy link
Contributor

rawwar commented Dec 14, 2023

@bilal-aamer , can you mark this PR as draft? Since, its a work in progress?

@bilal-aamer
Copy link
Author

Sure @rawwar

@dhrubo-os dhrubo-os marked this pull request as draft December 14, 2023 17:18
@bilal-aamer
Copy link
Author

Kindly guide me on the next steps.

@rawwar
Copy link
Contributor

rawwar commented Dec 18, 2023

Kindly guide me on the next steps.

I am sorry. I assumed you were still working on this. Do you have any specific doubts or issues you are facing?

@dhrubo-os
Copy link
Collaborator

@bilal-aamer are you working on this PR? Do you have any assistance here? If yes, please ask questions in details.

@bilal-aamer
Copy link
Author

Yes, I'm looking for some assistance on the next steps and/or resources to complete this draft PR

@rawwar
Copy link
Contributor

rawwar commented Feb 14, 2024

Yes, I'm looking for some assistance on the next steps and/or resources to complete this draft PR

Assuming you are looking for background knowledge, I would suggest you to go through this video to get started - Packaging your python code with pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants