Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/datetime64 #344

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

Prikshit7766
Copy link
Contributor

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rawwar
Copy link
Contributor

rawwar commented Nov 20, 2023

@dhrubo-os , I think this fix can be merged. This PR only solves the error. But, we also need to work on removing the pandas 1.5.x version pin on the tests

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc698a7) 91.36% compared to head (66bf912) 91.42%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   91.36%   91.42%   +0.06%     
==========================================
  Files          38       40       +2     
  Lines        4237     4339     +102     
==========================================
+ Hits         3871     3967      +96     
- Misses        366      372       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os
Copy link
Collaborator

@dhrubo-os , I think this fix can be merged. This PR only solves the error. But, we also need to work on removing the pandas 1.5.x version pin on the tests

Sure, Thanks for reviewing the PR.
@Prikshit7766 thanks for raising the PR.

@dhrubo-os dhrubo-os merged commit fb858dc into opensearch-project:main Nov 20, 2023
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants