Added deprecated module to setup.py Vinay Vinod <[email protected]> #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinay Vinod <[email protected]>
Vinay-Vinod
requested review from
dhrubo-os,
greaa-aws,
ylwu-amzn,
b4sjoo,
jngz-es and
rbhavna
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 40 40
Lines 4339 4339
=======================================
Hits 3967 3967
Misses 372 372 ☔ View full report in Codecov by Sentry. |
|
lint is failing. Could you please check? |
rawwar
reviewed
Nov 9, 2023
setup.py
Outdated
| @@ -87,6 +87,7 @@ | |||
| "pandas>=1.5,<3", | |||
| "matplotlib>=3.6.0,<4", | |||
| "numpy>=1.24.0,<2", | |||
| "deprecated" | |||
There was a problem hiding this comment.
Can we pinning it to version latest(1.2.14) or a compatible
rawwar
reviewed
Nov 13, 2023
Signed-off-by: Vinay Vinod <[email protected]>
|
@dhrubo-os , can you approve the workflows to run. I think this can be merged if tests are passing. |
|
@dhrubo-os , |
dhrubo-os
approved these changes
Nov 22, 2023
b4sjoo
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added deprecated module to setup.py
Issues Resolved
[BUG] deprecated library missing from install_requires list #315
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.