Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLCommonClient_client.upload_model #336

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix MLCommonClient_client.upload_model #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c01c5a
fix
rawwar Nov 6, 2023
74cd712
fix lint
rawwar Nov 6, 2023
b7378c6
update changelog
rawwar Nov 6, 2023
53a71cd
update changelog
rawwar Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Roll over pretrained_model_listing.json because of ml-commons dependency by @thanawan-atc in ([#252](https://github.com/opensearch-project/opensearch-py-ml/pull/252))
- Fix pandas dependency issue in nox session by installing pandas package to python directly by @thanawan-atc in ([#266](https://github.com/opensearch-project/opensearch-py-ml/pull/266))
- Fix conditional job execution issue in model upload workflow by @thanawan-atc in ([#294](https://github.com/opensearch-project/opensearch-py-ml/pull/294))
- fix bug in `MLCommonClient_client.upload_model` by @rawwar in ([#336](https://github.com/opensearch-project/opensearch-py-ml/pull/336))

## [1.1.0]

Expand Down
4 changes: 3 additions & 1 deletion opensearch_py_ml/ml_commons/ml_commons_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ def upload_model(
:rtype: string
"""
model_id = self._model_uploader._register_model(
model_path, model_config_path, isVerbose
model_path=model_path,
model_meta_path=model_config_path,
isVerbose=isVerbose,
)

# loading the model chunks from model index
Expand Down
Loading