Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove pin on the pandas version in nox tests #339

Closed
rawwar opened this issue Nov 9, 2023 · 4 comments · Fixed by #368
Closed

[FEATURE] Remove pin on the pandas version in nox tests #339

rawwar opened this issue Nov 9, 2023 · 4 comments · Fixed by #368
Labels
enhancement New feature or request untriaged

Comments

@rawwar
Copy link
Contributor

rawwar commented Nov 9, 2023

Currently, nox tests pin 1.5.0 version of pandas for tests. We should be removing this and actually testing with the version mentioned in the requirements.txt

opensearch-py-ml/noxfile.py

Line 106 in fc698a7

@nox.parametrize("pandas_version", ["1.5.0"])

@rawwar rawwar added enhancement New feature or request untriaged labels Nov 9, 2023
@mvarlamov222
Copy link

I can take this issue.

@rawwar
Copy link
Contributor Author

rawwar commented Nov 13, 2023

@mvarlamov222 , You would need to run tests after removing the version pin. Then, preferably mention the issues you see. Fixing them will close this issue.

@rawwar rawwar mentioned this issue Nov 16, 2023
Closed
5 tasks
@rawwar
Copy link
Contributor Author

rawwar commented Dec 2, 2023

@mvarlamov222 , do you need any help in completing this? If you can raise a draft PR with your work, I can probably help you out.

@mvarlamov222
Copy link

@mvarlamov222 , do you need any help in completing this? If you can raise a draft PR with your work, I can probably help you out.

Sorry, something has been wrong with my computer lately and sometimes it's working and at times it isn't. I made some changes, but I am not confident that they fix the issue, I can commit them today.

@rawwar rawwar mentioned this issue Jan 6, 2024
Merged
5 tasks
dhrubo-os pushed a commit that referenced this issue Feb 12, 2024
@rawwar
#339 : Remove separate pandas installations in nox tests (#368)
e0b1bcf 
* remove pins

Signed-off-by: kalyanr <[email protected]>

* fix

Signed-off-by: kalyanr <[email protected]>

* add changelog

Signed-off-by: kalyanr <[email protected]>

* fix

Signed-off-by: kalyanr <[email protected]>

* revert

Signed-off-by: kalyanr <[email protected]>

* remove

Signed-off-by: kalyanr <[email protected]>

* lint fixes

Signed-off-by: kalyanr <[email protected]>

---------

Signed-off-by: kalyanr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#339 : Remove separate pandas installations in nox tests rawwar/opensearch-py-ml
2 participants
@rawwar @mvarlamov222