Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings backwards compat documentation #15

Merged
merged 1 commit into from
May 10, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented May 6, 2021

Description

Assuming we go with this, documented updating settings. See opensearch-project/job-scheduler#20 for a working implementation. On top of #14.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the settings-backwards-compat branch from f1b41a6 to d0f0547 Compare May 7, 2021 15:17

7. Document your newly renamed settings.

TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aetter what should we write here? Where do I make changes for job-scheduler settings public documentation?

Copy link

@aetter aetter May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dblock, we actually have no user-facing content on job-scheduler since it plays such a supporting role. We deprioritized it early on and have never had a reader ask for anything. I'm happy to add a new top-level section to the documentation if you have content that you'd like to get out there. Just let me know. Otherwise, the most likely place is the job-scheduler README.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aetter What's another plugin link/example that we can put here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting is a decent example since the settings page also includes the managed indices and their purposes, which I assume might change during a migration. https://docs-beta.opensearch.org/docs/alerting/settings/#alerting-settings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and where's the source for that?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a link in the lower left to "edit this page" that should send you to the source. In this case, it's https://github.com/opensearch-project/documentation-website/blob/main/docs/alerting/settings.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I PRed #18.

It looks like we did a bunch of bulk replacement in the docs. Note that these don't correspond to reality in plugins for beta1 currently as none of the indices or settings should have been changed.

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dblock dblock merged commit 8a4b964 into opensearch-project:main May 10, 2021
@dblock dblock deleted the settings-backwards-compat branch May 11, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants