-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings backwards compat documentation #15
Settings backwards compat documentation #15
Conversation
72117c7
to
f1b41a6
Compare
Signed-off-by: dblock <[email protected]>
f1b41a6
to
d0f0547
Compare
|
||
7. Document your newly renamed settings. | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aetter what should we write here? Where do I make changes for job-scheduler settings public documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dblock, we actually have no user-facing content on job-scheduler since it plays such a supporting role. We deprioritized it early on and have never had a reader ask for anything. I'm happy to add a new top-level section to the documentation if you have content that you'd like to get out there. Just let me know. Otherwise, the most likely place is the job-scheduler README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aetter What's another plugin link/example that we can put here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting is a decent example since the settings page also includes the managed indices and their purposes, which I assume might change during a migration. https://docs-beta.opensearch.org/docs/alerting/settings/#alerting-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, and where's the source for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a link in the lower left to "edit this page" that should send you to the source. In this case, it's https://github.com/opensearch-project/documentation-website/blob/main/docs/alerting/settings.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I PRed #18.
It looks like we did a bunch of bulk replacement in the docs. Note that these don't correspond to reality in plugins for beta1 currently as none of the indices or settings should have been changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Assuming we go with this, documented updating settings. See opensearch-project/job-scheduler#20 for a working implementation. On top of #14.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.