[PROPOSAL] Delete the manual DCO check #61
Labels
enhancement
New feature or request
Comments
|
We have a DCO bot enabled for the org. The manual DCO check can be deleted. |
dblock
changed the title
rursprung
added a commit
to rursprung/opensearch-plugin-template-java
that referenced
this issue
Jun 20, 2024
the DCO check is activated directly on GitHub in the org-level settings for `opensearch-project` (see the [GitHub documentation]). there's no need for the duplicate check implemented in the workflow anymore. other projects which are created based on the template which want a DCO check can also just enable this in their settings. fixes opensearch-project#61 [GitHub documentation]: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-the-commit-signoff-policy-for-your-repository
rursprung
added a commit
to rursprung/opensearch-plugin-template-java
that referenced
this issue
Jun 20, 2024
the DCO check is activated directly on GitHub in the org-level settings for `opensearch-project` (see the [GitHub documentation]). there's no need for the duplicate check implemented in the workflow anymore. other projects which are created based on the template which want a DCO check can also just enable this in their settings. fixes opensearch-project#61 [GitHub documentation]: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-the-commit-signoff-policy-for-your-repository Signed-off-by: Ralph Ursprung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What/Why
What are you proposing?
currently, this repository is using the GH action workflow
dco.ymlto verify that a sign-off is provided. nowadays, this can be controlled directly via GitHub settings (see the GH documentation).for OpenSearch this has already been changed a year ago by @VachaShah in opensearch-project/OpenSearch#2317
if this is done it should also be documented that the same needs to be done on repositories started off of this template (presuming they want the DCO).
What users have asked for this feature?
n/a
What problems are you trying to solve?
align repositories, use standard features of GitHub.
What is the developer experience going to be?
n/a
Are there any security considerations?
n/a
Are there any breaking changes to the API
n/a
What is the user experience going to be?
n/a
Are there breaking changes to the User Experience?
n/a
Why should it be built? Any reason not to?
n/a
What will it take to execute?
Any remaining open questions?
n/a
The text was updated successfully, but these errors were encountered: