-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sample code to readme.md #103
Conversation
We have been writing https://github.com/opensearch-project/opensearch-php/blob/main/USER_GUIDE.md - is this duplicate? Maybe the README needs to be clearer to look there for sample code? I also think sample code should be runnable, or exercised in CI, and we would point to a working code, ideally. |
Yes, please add the link to the readme.md. I didn't see the sample codes. Also I have more examples in my sample code. You can add them. |
I have updated it and added a new commit |
@harrowmykel LGTM, please fix DCO with ( |
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage ? 26.96%
Complexity ? 1934
=======================================
Files ? 245
Lines ? 5544
Branches ? 0
=======================================
Hits ? 1495
Misses ? 4049
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Micheal Aro <[email protected]>
…p into dev/how-to-use
Ok. i have done that |
Signed-off-by: Harrowmykel <[email protected]>
…p into dev/how-to-use
@harrowmykel You have to sign all your commits or squash into one |
Description
This change adds a sample code to readme so that developers can easily get started
Issues Resolved
Closes #27 #46