Improve License Header Check #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
```sh perl -i -p0e 's|license\.\n\*\n\* Modifications|license.\n*/\n/*\n* Modifications|s' $(find . -iname '*.cs') ``` Signed-off-by: Thomas Farr <[email protected]>
|
The "true" diff can be checked locally, ignoring lines that are solely git diff --ignore-matching-lines '^(\*|/\*|\*/)$' main fix/license-header-check |
joshuali925
reviewed
Aug 16, 2022
joshuali925
approved these changes
Aug 16, 2022
|
@joshuali925, @dblock, should we add license header to non-code files? e.g. bash scripts, workflows and so on? |
Yes, I believe that's the right thing to do. But don't go crazy, like I rarely put those in GHA workflows for example. It only matters when people copy stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the license header check to only check for the SPDX header instead of the older header with explicit grants to Elasticsearch. This involves separating the old header block into two in all C# files to keep the checker happy.
I've split this into separate commits to see the "real" changes easier.
The replacement inside the C# files was entirely "mechanical" via:
Issues Resolved
Closes #69
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.