Fix for #375 - Added .Strict(bool) and .Verbatim(bool) methods on…
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DumboJetEngine
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
DumboJetEngine
force-pushed
the
fix_375
branch
4 times, most recently
from
6ba315a to
fb53012
Compare
Xtansia
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Hi @DumboJetEngine,
Apologies for taking a bit to getting to review this.
I've added a few comments with my thoughts.
src/OpenSearch.Client/QueryDsl/Abstractions/Container/QueryContainer-Dsl.cs
Show resolved
Hide resolved
src/OpenSearch.Client/QueryDsl/Abstractions/Container/QueryContainer-Dsl.cs
Show resolved
Hide resolved
src/OpenSearch.Client/QueryDsl/Visitor/QueryNodeModifierVisitor.cs
Outdated
Show resolved
Hide resolved
src/OpenSearch.Client/QueryDsl/Abstractions/Container/QueryContainer-Dsl.cs
Outdated
Show resolved
Hide resolved
src/OpenSearch.Client/QueryDsl/Abstractions/Container/QueryContainer-Dsl.cs
Outdated
Show resolved
Hide resolved
src/OpenSearch.Client/QueryDsl/Abstractions/Container/QueryContainer-Dsl.cs
Outdated
Show resolved
Hide resolved
DumboJetEngine
force-pushed
the
fix_375
branch
2 times, most recently
from
1636310 to
478d7e8
Compare
…ods on `QueryContainer` to help modify contained query attributes. (opensearch-project#375) Signed-off-by: Kostas <[email protected]>
DumboJetEngine
force-pushed
the
fix_375
branch
from
41ef3c1 to
6510ccb
Compare
Xtansia
approved these changes
Feb 6, 2024
|
Thanks @DumboJetEngine! |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-509-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e4f715e23cddceaf1268b06a48a1ffbc5fc3ffde
# Push it to GitHub
git push --set-upstream origin backport/backport-509-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
Xtansia
pushed a commit
to Xtansia/opensearch-net
that referenced
this pull request
Feb 6, 2024
…yContainer` to help modify contained query attributes. (opensearch-project#375) (opensearch-project#509) Signed-off-by: Kostas <[email protected]> (cherry picked from commit e4f715e)
dblock
pushed a commit
that referenced
this pull request
Feb 7, 2024
…yContainer` to help modify contained query attributes. (#375) (#509) (#539) Signed-off-by: Kostas <[email protected]> (cherry picked from commit e4f715e) Co-authored-by: DumboJetEngine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #375 - Added
.Strict(bool)and.Verbatim(bool)methods onQueryContainerthat recursively apply the respective attribute to all subqueries. Also added a.Name(string)method onQueryContainerthat names the (root) contained query.Issues Resolved
#375
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.