Fix null-ref exception when track total hits is disabled #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otuncelli
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
Signed-off-by: Osman Tunçelli <[email protected]>
Xtansia
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Hi @otuncelli, Thank you for the PR! The change looks good, only thing missing is adding an entry to the CHANGELOG.md under the Fixed header: https://github.com/opensearch-project/opensearch-net/blob/main/CHANGELOG.md#fixed
Signed-off-by: Osman Tunçelli <[email protected]>
Xtansia
approved these changes
Sep 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Fix null-ref exception when track total hits is disabled Signed-off-by: Osman Tunçelli <[email protected]> * update changelog Signed-off-by: Osman Tunçelli <[email protected]> --------- Signed-off-by: Osman Tunçelli <[email protected]> Co-authored-by: Osman Tunçelli <[email protected]> (cherry picked from commit fcfcae7)
Xtansia
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Fix null-ref exception when track total hits is disabled Signed-off-by: Osman Tunçelli <[email protected]> * update changelog Signed-off-by: Osman Tunçelli <[email protected]> --------- Signed-off-by: Osman Tunçelli <[email protected]> Co-authored-by: Osman Tunçelli <[email protected]> (cherry picked from commit fcfcae7) Co-authored-by: Osman Tunçelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
NullReferenceExceptionwhen accessingSearchResponse<TDocument>.Totalproperty ifTrackTotalHitsisfalse.Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.