Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE] Update org.apache.httpcomponents:httpclient to version '4.5.13' #855

Merged

Conversation

mikaylathompson
Copy link
Collaborator

Description

Fix for CVE-2020-13956

Issues Resolved

Testing

Only automated tests. The existing versions were either already this version or 4.5.12. Given it's a patch update, I beleive the automated tests should be sufficient, but let me know if there are any specific areas of concern.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <[email protected]>
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (eba85d6) to head (04ba338).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files          67       67           
  Lines        3723     3723           
=======================================
  Hits         3293     3293           
  Misses        430      430           
Flag Coverage Δ
python-test 88.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied changed the title Add httpclient constraint [CVE] Update org.apache.httpcomponents:httpclient to version '4.5.13' Jul 31, 2024
@sumobrian sumobrian merged commit ecac983 into opensearch-project:main Jul 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants