Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testDocumentGenerator defaults #772

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

AndreKurait
Copy link
Member

Description

Improve testDocumentGenerator defaults with 10 requests per second which allows for faster replay and fixes a bug that caused an incorrect sleep calculation.

  • Category: Enhancement
  • Why these changes are required? Improve usage
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Manual Testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (4bd3273) to head (706e6a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #772      +/-   ##
============================================
+ Coverage     68.53%   68.60%   +0.06%     
- Complexity     1577     1580       +3     
============================================
  Files           275      275              
  Lines         11660    11660              
  Branches        737      737              
============================================
+ Hits           7991     7999       +8     
+ Misses         3263     3257       -6     
+ Partials        406      404       -2     
Flag Coverage Δ
gradle-test 61.29% <ø> (+0.09%) ⬆️
python-test 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait marked this pull request as ready for review June 26, 2024 16:17
@peternied peternied merged commit a548ab8 into opensearch-project:main Jun 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants