Fix Jackson deserialization for 7.17 snapshot repo data #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
force-pushed
the
FixJacksonSerialization
branch
from
4e39e89 to
bfe11fa
Compare
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
============================================
+ Coverage 63.89% 63.96% +0.06%
- Complexity 1584 1585 +1
============================================
Files 223 223
Lines 9092 9093 +1
Branches 771 771
============================================
+ Hits 5809 5816 +7
+ Misses 2874 2869 -5
+ Partials 409 408 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
peternied
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Lets not merge this until we've got a unit tests. First one is free - AndreKurait#3
Add a test case to make sure deserialization is tested for snapshots
peternied
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Jackson deserialization for 7.17 snapshot repo data
Issues Resolved
N/A
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Manual testing in the cloud with a self managed 7.17.21 cluster on the migration console
TODO in a followup task. Automated testing added for various versions
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.