-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a few bugs in the gradle setup for rfs #736
Conversation
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
============================================
+ Coverage 57.41% 64.01% +6.59%
- Complexity 0 1588 +1588
============================================
Files 11 223 +212
Lines 573 9092 +8519
Branches 0 771 +771
============================================
+ Hits 329 5820 +5491
- Misses 244 2862 +2618
- Partials 0 410 +410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look. Let's quickly follow up on if we can get 7_17 working for the demo
.withTag("latest") | ||
.exec() | ||
} | ||
} | ||
|
||
task removeClientContainer(type: DockerRemoveContainer) { | ||
dependsOn waitClientContainer | ||
dependsOn commitSourceContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would you need to wait for the source to be committed? Shouldn't the client finishing be independent of when the sync happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. We probably don't need to do this, but it made the sequence of operations clearer in my mind when I was trying to figure out why the commitSourceContainer
task didn't appear to be firing. In reality the commit task was firing, it just didn't report anything to stdout.
Description
Issues Resolved
N/A
Testing
manual testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.