Fix IllegalArgumentException in Replayer logging #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
peternied
reviewed
May 5, 2024
...re/trafficReplayer/src/main/java/org/opensearch/migrations/replay/ResultsToLogsConsumer.java
Show resolved
Hide resolved
peternied
reviewed
May 5, 2024
...cCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
May 5, 2024
...ture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayerCore.java
Outdated
Show resolved
Hide resolved
AndreKurait
force-pushed
the
LoggingArgumentOverConcatenation
branch
from
2690924 to
6b88953
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=========================================
Coverage 75.79% 75.80%
- Complexity 1543 1548 +5
=========================================
Files 168 168
Lines 6437 6455 +18
Branches 575 575
=========================================
+ Hits 4879 4893 +14
- Misses 1179 1184 +5
+ Partials 379 378 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
force-pushed
the
LoggingArgumentOverConcatenation
branch
from
6b88953 to
9ca9f29
Compare
AndreKurait
changed the title
Signed-off-by: Andre Kurait <[email protected]>
peternied
approved these changes
May 9, 2024
|
@AndreKurait Could you look into the CI failures before merging? |
gregschohn
reviewed
May 9, 2024
| @@ -72,7 +72,7 @@ appender.ALL_ACTIVE_WORK_MONITOR_LOGFILE.strategy.type = DefaultRolloverStrategy | |||
| appender.ALL_ACTIVE_WORK_MONITOR_LOGFILE.strategy.max = 4 | |||
| appender.ALL_ACTIVE_WORK_MONITOR_LOGFILE.immediateFlush = false | |||
|
|
|||
| rootLogger.level = info | |||
| rootLogger.level = trace | |||
Signed-off-by: Andre Kurait <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes illegal argument exception in a few places where the replayer logs messages contain "{}".
Issues Resolved
Progress towards Bug #633
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Ran some end to end testing locally with various log levels and checking for errors.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.