Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating maintainers list, adding Peter #627

Merged
merged 4 commits into from
May 2, 2024

Conversation

sumobrian
Copy link
Collaborator

Description

Adding @peternied to list of maintainers and @kartg to emeritus list.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MAINTAINERS.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76%. Comparing base (4994898) to head (495b27c).
Report is 12 commits behind head on main.

❗ Current head 495b27c differs from pull request most recent head 30b7e8f. Consider uploading reports for the commit 30b7e8f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #627      +/-   ##
============================================
- Coverage     75.77%   75.76%   -0.02%     
  Complexity     1533     1533              
============================================
  Files           168      168              
  Lines          6395     6395              
  Branches        570      570              
============================================
- Hits           4846     4845       -1     
- Misses         1172     1173       +1     
  Partials        377      377              
Flag Coverage Δ
unittests 75.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Peter Nied <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Copy link
Member

@AndreKurait AndreKurait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please add peter to write access to repo and remove karthg before merging this PR

@AndreKurait
Copy link
Member

Approved, please add peter to write access to repo and remove karthg before merging this PR

@opensearch-project/admin

@bbarani
Copy link
Member

bbarani commented May 2, 2024

Removed @kartg and added @peternied as one of the maintainer of this repo.

@peternied
Copy link
Member

@peternied peternied merged commit 8b52bdf into opensearch-project:main May 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants