Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Migration Console build directory on gradle clean #625

Merged

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented May 1, 2024

Description

Minor bug fix of additional build dir cleanup

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Local manual build testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.90%. Comparing base (4994898) to head (80047fb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #625      +/-   ##
============================================
+ Coverage     75.77%   75.90%   +0.12%     
- Complexity     1533     1536       +3     
============================================
  Files           168      168              
  Lines          6395     6395              
  Branches        570      570              
============================================
+ Hits           4846     4854       +8     
+ Misses         1172     1167       -5     
+ Partials        377      374       -3     
Flag Coverage Δ
unittests 75.90% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewijacn lewijacn merged commit 15e84b2 into opensearch-project:main May 2, 2024
7 checks passed
@lewijacn lewijacn deleted the remove-console-build-dir branch May 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants