-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RFS Docker Compose to handle AWS Creds; fix S3Repo bug #597
Conversation
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
@@ -8,6 +8,9 @@ services: | |||
environment: | |||
- discovery.type=single-node | |||
- path.repo=/snapshots | |||
- AWS_ACCESS_KEY_ID=${access_key} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason you're not using the typical env var naming conventions locally? (e.g. not - AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
and the corresponding change in the documentation). Not a big deal, but I'm not sure I understand the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so that you can use a different set of credentials on the host machine if you want to. I was having trouble with my host machine (mac laptop) picking up and using the creds intended for the RFS Containers, which was pretty annoying because that meant that when I ran the AWS CLI to get renewed creds for the Containers using STS, the CLI would use the expired credential set I was trying to renew! 🙃
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <[email protected]> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <[email protected]> --------- Signed-off-by: Chris Helma <[email protected]> Signed-off-by: Andre Kurait <[email protected]>
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <[email protected]> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <[email protected]> --------- Signed-off-by: Chris Helma <[email protected]>
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <[email protected]> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <[email protected]> --------- Signed-off-by: Chris Helma <[email protected]> Signed-off-by: Mikayla Thompson <[email protected]>
Description
Issues Resolved
Done while working on https://opensearch.atlassian.net/browse/MIGRATIONS-1600
Testing
./gradlew tests
)Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.