Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFS] Make indexSuffix a parameter #596

Merged

Conversation

mikaylathompson
Copy link
Collaborator

Description

  • Category : Enhancement
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?
    • Previously all indices were suffixed with _reindexed. Now, they are

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-1672

Testing

Manual testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <[email protected]>
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.91%. Comparing base (2b853a9) to head (384401e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
+ Coverage     75.74%   75.91%   +0.17%     
+ Complexity     1495     1491       -4     
============================================
  Files           162      162              
  Lines          6348     6348              
  Branches        572      572              
============================================
+ Hits           4808     4819      +11     
+ Misses         1160     1152       -8     
+ Partials        380      377       -3     
Flag Coverage Δ
unittests 75.91% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chelma chelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikaylathompson mikaylathompson merged commit a35d041 into opensearch-project:main Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants