Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Drafter and Traffic Capture to define a variable for publishing version based on tag #582

Merged

Conversation

AndreKurait
Copy link
Member

Description

Previously, the Traffic Capture maven artifacts were always published under version 0.1.0. Now, the version will be based on the cut tag with the preface of 0. signaling the potential for class interface changes.

  • Category: Enhancement
  • Why these changes are required? In order to publish subsequent releases and release candidates, the version needs to be based on the tag
  • What is the old behavior before changes and new behavior after changes? Version was hardcoded at 0.1.0, now it is configurable based on tag

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-1606

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Check List

  • [ N/A ] New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait marked this pull request as ready for review April 16, 2024 06:15
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (fe88c1e) to head (0dee0f9).
Report is 9 commits behind head on main.

❗ Current head 0dee0f9 differs from pull request most recent head 2b853a9. Consider uploading reports for the commit 2b853a9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #582      +/-   ##
============================================
- Coverage     76.03%   75.72%   -0.31%     
+ Complexity     1503     1490      -13     
============================================
  Files           162      162              
  Lines          6359     6348      -11     
  Branches        567      572       +5     
============================================
- Hits           4835     4807      -28     
- Misses         1151     1163      +12     
- Partials        373      378       +5     
Flag Coverage Δ
unittests 75.72% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zelinh zelinh deleted the branch opensearch-project:main April 16, 2024 20:17
@zelinh zelinh closed this Apr 16, 2024
@sumobrian sumobrian reopened this Apr 16, 2024
@AndreKurait AndreKurait force-pushed the MavenReleaseVersionUpdate branch from 0dee0f9 to 5743157 Compare April 16, 2024 23:07
…ublishing version based on tag

Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait AndreKurait reopened this Apr 16, 2024
@AndreKurait AndreKurait merged commit 4ec659b into opensearch-project:main Apr 16, 2024
7 of 8 checks passed
@AndreKurait AndreKurait deleted the MavenReleaseVersionUpdate branch April 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants