Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot publish and snapshot version property #568

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Apr 9, 2024

Description

Add snapshot publish and snapshot version property

  • Category: Enhancement
  • Why these changes are required? Prereq for maven publishing
  • What is the old behavior before changes and new behavior after changes? When -Dbuild.snapshot=false is provided, snapshot will not be included in the version tag.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-1606

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran publish commands locally with and without -Dbuild.snapshot=false

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait marked this pull request as ready for review April 9, 2024 22:21
@AndreKurait AndreKurait force-pushed the MavenTagRemoveSnapshot branch from 9274ea2 to 5279b50 Compare April 9, 2024 22:24
@AndreKurait AndreKurait merged commit 95ff189 into opensearch-project:main Apr 9, 2024
5 checks passed
@AndreKurait AndreKurait deleted the MavenTagRemoveSnapshot branch April 9, 2024 22:33
@AndreKurait AndreKurait restored the MavenTagRemoveSnapshot branch April 9, 2024 23:04
@AndreKurait AndreKurait deleted the MavenTagRemoveSnapshot branch April 9, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants