Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RFS runnable as Container #550
Make RFS runnable as Container #550
Changes from 1 commit
ce57d34
48a0843
8167eec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, this is actually more potentially confusing than I thought originally. Per our convo, before ES 7.8, there was only
templates
, so if you use the script to migrate a 6.8 cluster you wouldn't see an appropriate option.Would you mind changing
--index-template-whitelist
to--templates-whitelist
and updating the description to indicate it refers to legacy templates for ES 6.8 and index templates for 7.10? Not a perfect fix long term, but probably enough for the moment.TBH, this argument list is getting pretty long an gnarly. Not sure what to do about it right now, but we should think about ways to make it easier to navigate the many different use-cases it's trying to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, we'll also want a check so that
--component-templates
aren't supplied to a ES 6.8 migration.I'm wondering if we want different wrapper scripts for different source versions, or something...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a follow-up JIRA for this: https://opensearch.atlassian.net/browse/MIGRATIONS-1646
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per comment for now. Need to think about this more but having a pattern for handling different arguments for different versions could be nice