-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Limitless CodedOutputStreams #543
Support Limitless CodedOutputStreams #543
Conversation
Signed-off-by: Andre Kurait <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there already a test in place that wwill make sure that the limit updating is properly applied and honored? I think that there are some. If you make the limit calculations break, which tests will fail? As long as it's some tests, the approach & testing look good. Though, I'd like to see a helper function that gets the outputstream from the holder to keep the patch tighter and the code shorter.
.../java/org/opensearch/migrations/trafficcapture/StreamChannelConnectionCaptureSerializer.java
Outdated
Show resolved
Hide resolved
b23f655
to
f697eb3
Compare
Signed-off-by: Andre Kurait <[email protected]>
f697eb3
to
6e490f7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
============================================
+ Coverage 76.40% 76.59% +0.18%
- Complexity 1383 1398 +15
============================================
Files 154 155 +1
Lines 5975 5985 +10
Branches 538 538
============================================
+ Hits 4565 4584 +19
+ Misses 1043 1039 -4
+ Partials 367 362 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nCaptureSerializerTest Signed-off-by: Andre Kurait <[email protected]>
Description
This change adds functionality within the CodedOutputStreamHolder and refactors the StreamChannelConnectionCaptureSerializer to support limitless CodedOutputStreams through new interface method
getOutputStreamBytesLimit
which can be set to the limit of an underlying byte buffer or-1
for a limitless CodedOutputStreams.--noCapture
parameter is broken and prevents proxy functionality.--noCapture
prevents proxy from forwarding requests to the destination, with this change the proxy behaves as expectedIssues Resolved
Issues#540
MIGRATIONS-1616
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Unit Tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.