Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cdk to follow opensearch-project standards #529

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Feb 27, 2024

Description

Rename cdk to follow opensearch-project standards, a prereq to npmjs publishing. Also adds improvements like adding the License file to cdk submodule, adding a type declaration for InvokeCommandInput given observed build failures depending on cdk version, and updating the package.json to make the import work naturally when adding as a library.

  • Category: Enhancement
  • Why these changes are required? to publish to the opensearch-project npmjs org and use package as a library
  • What is the old behavior before changes and new behavior after changes? name changes to package

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

npm run test

Check List

  • [x ] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (7eaf632) to head (37cac7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #529   +/-   ##
=========================================
  Coverage     76.88%   76.88%           
- Complexity     1386     1388    +2     
=========================================
  Files           158      158           
  Lines          6105     6105           
  Branches        532      532           
=========================================
  Hits           4694     4694           
- Misses         1059     1062    +3     
+ Partials        352      349    -3     
Flag Coverage Δ
unittests 76.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait AndreKurait merged commit c209363 into opensearch-project:main Mar 7, 2024
7 checks passed
@AndreKurait AndreKurait deleted the cdk-package-rename branch March 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants