-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cdk to follow opensearch-project standards #529
Merged
AndreKurait
merged 9 commits into
opensearch-project:main
from
AndreKurait:cdk-package-rename
Mar 7, 2024
Merged
Rename cdk to follow opensearch-project standards #529
AndreKurait
merged 9 commits into
opensearch-project:main
from
AndreKurait:cdk-package-rename
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
requested review from
chelma,
gregschohn,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
February 27, 2024 18:19
Signed-off-by: Andre Kurait <[email protected]>
…nput Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=========================================
Coverage 76.88% 76.88%
- Complexity 1386 1388 +2
=========================================
Files 158 158
Lines 6105 6105
Branches 532 532
=========================================
Hits 4694 4694
- Misses 1059 1062 +3
+ Partials 352 349 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
reviewed
Mar 5, 2024
Signed-off-by: Andre Kurait <[email protected]>
lewijacn
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename cdk to follow opensearch-project standards, a prereq to npmjs publishing. Also adds improvements like adding the License file to cdk submodule, adding a type declaration for InvokeCommandInput given observed build failures depending on cdk version, and updating the package.json to make the import work naturally when adding as a library.
Issues Resolved
N/A
Is this a backport? If so, please add backport PR # and/or commits #
N/A
Testing
npm run test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.