-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK Extensibility Improvments #525
Merged
AndreKurait
merged 8 commits into
opensearch-project:main
from
AndreKurait:CDKFixImports
Feb 27, 2024
Merged
CDK Extensibility Improvments #525
AndreKurait
merged 8 commits into
opensearch-project:main
from
AndreKurait:CDKFixImports
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
…ncies Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
requested review from
chelma,
gregschohn,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
February 24, 2024 02:28
Signed-off-by: Andre Kurait <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
============================================
- Coverage 76.87% 76.82% -0.05%
+ Complexity 1389 1386 -3
============================================
Files 158 158
Lines 6105 6105
Branches 532 532
============================================
- Hits 4693 4690 -3
- Misses 1061 1063 +2
- Partials 351 352 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
approved these changes
Feb 26, 2024
Apologies was hoping my previous merge wouldn't cause conflicts |
Signed-off-by: Andre Kurait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes the existing CDK more extensible into other CDK projects by streamlining package imports, moving cdk dependencies to peerDependencies. This change also makes it so build artifacts to be published in library are exported in dist directory.
This is a requirement to expose the cdk code as a library to other cdk apps.
Issues Resolved
MIGRATIONS-1520
Is this a backport? If so, please add backport PR # and/or commits #
No
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.