Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK Extensibility Improvments #525

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

AndreKurait
Copy link
Member

Description

This change makes the existing CDK more extensible into other CDK projects by streamlining package imports, moving cdk dependencies to peerDependencies. This change also makes it so build artifacts to be published in library are exported in dist directory.
This is a requirement to expose the cdk code as a library to other cdk apps.

  • Category: Enhancement
  • Why these changes are required? Extensibility of the deployment artifacts.
  • What is the old behavior before changes and new behavior after changes? CDK would be difficult to integrate into other packages requiring overrides or changes in cdk version.

Issues Resolved

MIGRATIONS-1520

Is this a backport? If so, please add backport PR # and/or commits #
No

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (d99fc03) to head (e7e37a1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #525      +/-   ##
============================================
- Coverage     76.87%   76.82%   -0.05%     
+ Complexity     1389     1386       -3     
============================================
  Files           158      158              
  Lines          6105     6105              
  Branches        532      532              
============================================
- Hits           4693     4690       -3     
- Misses         1061     1063       +2     
- Partials        351      352       +1     
Flag Coverage Δ
unittests 76.82% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewijacn
Copy link
Collaborator

Apologies was hoping my previous merge wouldn't cause conflicts

@AndreKurait AndreKurait merged commit d38e58a into opensearch-project:main Feb 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants