-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local maven publish #521
Local maven publish #521
Conversation
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
============================================
+ Coverage 76.71% 76.87% +0.15%
- Complexity 1385 1389 +4
============================================
Files 158 158
Lines 6086 6105 +19
Branches 532 532
============================================
+ Hits 4669 4693 +24
- Misses 1059 1061 +2
+ Partials 358 351 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
api group: 'io.netty', name: 'netty-buffer', version: '4.1.100.Final' | ||
api group: 'io.netty', name: 'netty-codec-http', version: '4.1.100.Final' | ||
api group: 'io.netty', name: 'netty-handler', version: '4.1.100.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this used to be picked up via a BOM. Do you know why you had to specify the version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed otherwise the external gradle project has to define the version to use.
If this was picked up via a BOM, then I think it was sparsely used throughout the project as explicitly specifying the netty version seemed more common
Description
Adds support for local maven repo publish
Issues Resolved
MIGRATIONS-1508
Is this a backport? If so, please add backport PR # and/or commits #
No
Testing
Created a sample external gradle project and imported all projects and attempted to build with some class imports.
Extract from test project build.gradle:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.