Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gradle Build Scans #518

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Feb 21, 2024

Description

Enable Gradle Build Scans with option to auto agree to tos and add scan for all runs. Approved by AWS Security (Internal Ticket V1251862415)

  • Category - New Feature
  • Why these changes are required? Currently it is very difficult to debug failues in git workflows for test/build execution. This enables gradle scan which uploads and provides a UI for this.
  • What is the old behavior before changes and new behavior after changes? Before, no scan published, now Scan published.

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

View Actions Results in this PR. Ran with --scan, --no-scan and no parameter with and without the env variable set to confirm behavior.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (9fedef8) to head (7220d66).
Report is 1 commits behind head on main.

❗ Current head 7220d66 differs from pull request most recent head b70650a. Consider uploading reports for the commit b70650a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #518      +/-   ##
============================================
+ Coverage     76.80%   77.03%   +0.22%     
  Complexity     1388     1388              
============================================
  Files           158      158              
  Lines          6105     6105              
  Branches        532      532              
============================================
+ Hits           4689     4703      +14     
+ Misses         1065     1052      -13     
+ Partials        351      350       -1     
Flag Coverage Δ
unittests 77.03% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/e2eTest.yml Show resolved Hide resolved
TrafficCapture/settings.gradle Outdated Show resolved Hide resolved
@AndreKurait AndreKurait changed the title Enable Gradle Build Scans for CI/CD Enable Gradle Build Scans Feb 23, 2024
.github/workflows/gradle-build-and-test.yml Outdated Show resolved Hide resolved
TrafficCapture/settings.gradle Outdated Show resolved Hide resolved
TrafficCapture/gradlew Outdated Show resolved Hide resolved
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided that there's nothing alarming in the checks

@AndreKurait AndreKurait merged commit bc31bff into opensearch-project:main Feb 29, 2024
4 of 5 checks passed
@AndreKurait AndreKurait deleted the EnableGradleScan branch February 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants