Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Fetch Migration stability #516

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Improvements to Fetch Migration stability #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion FetchMigration/python/progress_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ def update_records_in_flight_count(self, rec_in_flight: Optional[int]):
self.__record_value(self._REC_IN_FLIGHT_KEY, rec_in_flight)

def update_no_partitions_count(self, no_part_count: Optional[int]):
self.__record_value(self._NO_PART_KEY, no_part_count)
if no_part_count and no_part_count > 0:
self.__record_value(self._NO_PART_KEY, no_part_count)

def get_doc_completion_percentage(self) -> int:
success_doc_count = self.__get_current_value(self._SUCCESS_DOCS_KEY)
Expand Down
6 changes: 5 additions & 1 deletion deployment/cdk/opensearch-service-migration/dp_pipeline_template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ historical-data-migration:
connection:
insecure: true
# Additional pipeline options/optimizations
buffer:
bounded_blocking: # Values recommended by an expert
buffer_size: 1000000
batch_size: 12500
# For maximum throughput, match workers to number of vCPUs (default: 1)
workers: 1
workers: 2
# delay is how often the worker threads should process data (default: 3000 ms)
delay: 0
4 changes: 2 additions & 2 deletions deployment/cdk/opensearch-service-migration/lib/fetch-migration-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ export class FetchMigrationStack extends Stack {
// ECS Task Definition
const fetchMigrationFargateTask = new FargateTaskDefinition(this, "fetchMigrationFargateTask", {
family: `migration-${props.stage}-${serviceName}`,
memoryLimitMiB: 4096,
cpu: 1024,
memoryLimitMiB: 8192,
cpu: 2048,
taskRole: ecsTaskRole
});

Expand Down
1 change: 1 addition & 0 deletions deployment/cdk/opensearch-service-migration/lib/service-stacks/migration-service-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export class MigrationServiceCore extends Stack {
props.taskRolePolicies?.forEach(policy => serviceTaskRole.addToPolicy(policy))

const serviceTaskDef = new FargateTaskDefinition(this, "ServiceTaskDef", {
ephemeralStorageGiB: 75,
family: `migration-${props.stage}-${props.serviceName}`,
memoryLimitMiB: props.taskMemoryLimitMiB ? props.taskMemoryLimitMiB : 1024,
cpu: props.taskCpuUnits ? props.taskCpuUnits : 256,
Expand Down