Flaky tcp connection trace test fix #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was in shutdown logic. Cleanup work was being done for some connection data structures from threads other than the assigned eventloop one, causing exception. Signed-off-by: Greg Schohn <[email protected]>
…StreamWithRequestsWithCloseIsCommittedOnce that prevented a potentially second call to shutdown. The latest code does a join() on the shutdown call before it proceeds to shut down the http server. That seemed to be more important for a stable test, especially since it's a valid use of a second shutdown. Signed-off-by: Greg Schohn <[email protected]> # Conflicts: # TrafficCapture/trafficReplayer/src/test/java/org/opensearch/migrations/replay/FullReplayerWithTracingChecksTest.java
…e target itself. This made the code WAAYYYY simpler too. Signed-off-by: Greg Schohn <[email protected]>
gregschohn
requested review from
AndreKurait,
chelma,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
Signed-off-by: Greg Schohn <[email protected]>
AndreKurait
reviewed
Feb 16, 2024
...r/src/main/java/org/opensearch/migrations/replay/datahandlers/NettyPacketToHttpConsumer.java
Show resolved
Hide resolved
AndreKurait
reviewed
Feb 16, 2024
...player/src/test/java/org/opensearch/migrations/replay/FullReplayerWithTracingChecksTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Greg Schohn <[email protected]>
AndreKurait
approved these changes
Feb 16, 2024
gregschohn
added a commit
to gregschohn/opensearch-migrations
that referenced
this pull request
Feb 20, 2024
Bugfixes and minor logging improvements. Move tcpConnection tracing into the netty channel that connects to the target itself. This made the code WAAYYYY simpler too. There was a bug in shutdown logic. Cleanup work was being done for some connection data structures from threads other than the assigned eventloop one, causing exception. Signed-off-by: Greg Schohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tcpConnections weren't being properly tracked. Now they are because they're tied to the netty channel itself. I've also improved some logging and fixed a multi-threading bug in shutdown.
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1502
Testing
./gradlew build slowTest
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.