Enhancements in StreamChannelConnectionCaptureSerializer

[AndreKurait]

Description

This pull request introduces two key enhancements to the StreamChannelConnectionCaptureSerializer:

• Increasing the StreamChannelConnectionCaptureSerializer's max ID size.
• Refactoring the StreamChannelConnectionCaptureSerializerTest with a calculated bufferSize and added test for maxID sizes.

• Category: Bug fix, Refactoring
• These changes are required to fix max id size assertion in StreamChannelConnectionCaptureSerializer which currently is not large enough to allow for kafka connectionIds when executed with assertions enabled.
• Old behavior: Threw assertion error when starting up with -ea jdk flag.
• New behavior: No StreamChannelConnectionCaptureSerializer assertion error during startup with -ea.

Issues Resolved

• MIGRATIONS-1490

Is this a backport? If so, please add backport PR # and/or commits #

• N/A

Testing

• Unit testing have been conducted to ensure functionality with new tests added to verify behavior
• Manual testing has been performed to verify the changes via starting up dockerSolution with -enableassertions with OSB --test script and doc count check

Check List

• New functionality includes testing
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af612a3) 73.49% compared to head (25e86f2) 73.53%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #494      +/-   ##
============================================
+ Coverage     73.49%   73.53%   +0.04%     
- Complexity     1180     1181       +1     
============================================
  Files           124      124              
  Lines          4886     4886              
  Branches        439      439              
============================================
+ Hits           3591     3593       +2     
+ Misses         1000      999       -1     
+ Partials        295      294       -1     

Flag	Coverage Δ
unittests	73.53% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AndreKurait]

@gregschohn, let me know if we should increase this as 100 is exactly what we expect out of our realIds

[gregschohn]

I don't have a strong opinion. If I were doing this code from scratch, I'd probably put an assertion that I could create a new CodedOutputStream from the factory that was able to write the boilerplate stuff - all within a lambda inside the assert statement.

[gregschohn]

I'd like to see the mockito test get dropped & the code that it was testing improve. I'd recommend filing an issue to improve it & leave that dragon sleep for the moment.

[gregschohn]

I don't have a strong opinion. If I were doing this code from scratch, I'd probably put an assertion that I could create a new CodedOutputStream from the factory that was able to write the boilerplate stuff - all within a lambda inside the assert statement.