Python Integ Test Updates #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
chelma,
gregschohn,
kartg,
mikaylathompson,
okhasawn and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
============================================
+ Coverage 73.51% 73.55% +0.04%
- Complexity 1180 1182 +2
============================================
Files 124 124
Lines 4886 4886
Branches 439 439
============================================
+ Hits 3592 3594 +2
+ Misses 999 998 -1
+ Partials 295 294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tanner Lewis <[email protected]>
okhasawn
approved these changes
Jan 15, 2024
|
|
||
| def test_0001_index(self): | ||
| # This test will verify that an index will be created (then deleted) on the target cluster when one is created | ||
| # on the source cluster by going through the proxy first. It will verify that the traffic is captured by the | ||
| # proxy and that the traffic reaches the source cluster, replays said traffic to the target cluster by the | ||
| # replayer. | ||
|
|
||
| index_name = f"test_0001_{self.unique_id}" |
There was a problem hiding this comment.
I very much appreciate this change so that concurrent build jobs can be running the same test without causing any conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change contains improvements and refactors to the integration test script we have currently. It fixes some indentation errors that occurred at some point with the OSB test which was causing some indexes to not get checked. It also adds additional logic for the OSB test to add proper parameters for the
./runTestBenchmarksscript. Also included is a refactoring to not try and delete a given index after every test which can cause some flakiness between tests if using the proxy endpoint. Instead we use a unique index for each test now, and let the test delete the index if it chooses.Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.