Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop user agent matches and a bugfix for over-committing KafkaRecords too early #468

Merged
merged 7 commits into from
Dec 11, 2023

Merge branch 'main' into DropUserAgentMatches - purged erroneous Kafk…

9fa9ff0
Select commit
Loading
Failed to load commit list.
Merged

Drop user agent matches and a bugfix for over-committing KafkaRecords too early #468

Merge branch 'main' into DropUserAgentMatches - purged erroneous Kafk…
9fa9ff0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 8, 2023 in 1s

72.88% (-3.98%) compared to 908f360

View this Pull Request on Codecov

72.88% (-3.98%) compared to 908f360

Details

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (908f360) 76.86% compared to head (9fa9ff0) 72.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
...tions/trafficcapture/proxyserver/CaptureProxy.java 6.66% 14 Missing ⚠️
...y/CapturedTrafficToHttpTransactionAccumulator.java 69.23% 5 Missing and 3 partials ⚠️
...h/migrations/replay/ParsedHttpMessagesAsDicts.java 46.66% 2 Missing and 6 partials ⚠️
...onditionallyReliableLoggingHttpRequestHandler.java 50.00% 1 Missing and 3 partials ⚠️
...rafficcapture/netty/LoggingHttpRequestHandler.java 90.00% 0 Missing and 4 partials ⚠️
...h/migrations/replay/RequestSenderOrchestrator.java 90.90% 1 Missing and 1 partial ⚠️
.../opensearch/migrations/replay/TrafficReplayer.java 50.00% 2 Missing ⚠️
...y/datahandlers/http/NettyJsonToByteBufHandler.java 0.00% 2 Missing ⚠️
...earch/migrations/replay/datatypes/ChannelTask.java 33.33% 2 Missing ⚠️
...search/migrations/replay/datatypes/RawPackets.java 75.00% 0 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #468      +/-   ##
============================================
- Coverage     76.86%   72.88%   -3.98%     
- Complexity     1151     1165      +14     
============================================
  Files           145      124      -21     
  Lines          5887     4846    -1041     
  Branches        542      436     -106     
============================================
- Hits           4525     3532     -993     
+ Misses         1080     1021      -59     
- Partials        282      293      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov