Add E2E AWS Integration Testing Script #462
Conversation
Signed-off-by: Tanner Lewis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=========================================
Coverage 73.55% 73.55%
Complexity 1182 1182
=========================================
Files 124 124
Lines 4886 4886
Branches 439 439
=========================================
Hits 3594 3594
Misses 998 998
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
chelma,
gregschohn,
kartg,
mikaylathompson,
okhasawn and
sumobrian
as code owners
…ated SSM parameters Signed-off-by: Tanner Lewis <[email protected]>
| } | ||
| EOM | ||
|
|
||
| git clone https://github.com/lewijacn/opensearch-cluster-cdk.git || echo "Repo already exists, skipping.." |
There was a problem hiding this comment.
I'm guessing we're going to eventually change the location of the cdk code here.
There was a problem hiding this comment.
Not sure what our future plan will be around this, as I don't think it makes sense to have an official repo for it right now but would like to have it linked to the team somehow. For now I have gone ahead and given team members collaborator access to this repo to make changes as needed
TrafficCapture/dockerSolution/src/main/docker/migrationConsole/setupIntegTests.sh
Show resolved
Hide resolved
|
|
||
| cdk_context=$(echo "${cdk_context/<VPC_ID>/$vpc_id}") | ||
| cdk_context=$(echo "${cdk_context/<SOURCE_CLUSTER_ENDPOINT>/http://${source_endpoint}}") | ||
| cdk_context=$(echo $cdk_context | jq '@json') |
There was a problem hiding this comment.
Is jqguaranteed to be installed or should it be listed as a dependency?
There was a problem hiding this comment.
This script takes on all the dependencies of our solution (and additionally jq). Have added a disclaimer to the top of the file mentioning this
| git_http_url=$1 | ||
| branch=$2 |
There was a problem hiding this comment.
Can you update the usage of these variables within this file to be double quoted please?
e.g on line 14: git remote add -f origin "$git_http_url"
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Description
This change adds a bash script for setting up a full E2E AWS setup including a source cluster running ES 7.10 on EC2 nodes as well as our migration solution and target cluster on OS 2.X. This will be useful for our integration tests to run and set up the needed environment for testing, but can also be utilized by developers to deploy this E2E setup in their own configured AWS account by simply running the script.
Issues Resolved
N/A
Testing
Manual deployment testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.