-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel metrics and traces #460
Merged
gregschohn
merged 21 commits into
opensearch-project:main
from
gregschohn:OtelMetricsAndTraces
Feb 9, 2024
+1,413
−451
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a4caca7
Move addMetricsIfPresent into the metrics builder as a first class me…
gregschohn c026588
WIP to play with OpenTelemetry metric instruments and tracer spans.
gregschohn f3c0077
Get gradle files and docker-compose in order to support otlp exports …
gregschohn 7fb8e2e
WIP
gregschohn a8ae3d1
Restore the docker-compose single-node/multi-node split docker-compos…
gregschohn da9d36b
Add labels to each metric instrument so that multiple values can be p…
gregschohn 06618ca
Move the MetricsClosure into its own class and stop stuffing the metr…
gregschohn aba1aab
WIP - Cleanup + get Jaeger to work by switching the endpoint. Also i…
gregschohn 900bc6d
Start moving away from ThreadLocal and 'current contexts' and toward …
gregschohn 3746a8e
Get span parenting to work.
gregschohn e0e7bf1
Merge branch 'main' into DoNotMerge_MoreMetrics
gregschohn 4b43262
Attempt to fix a failing unit test.
gregschohn 322e12f
Refactor. Couple name changes, class package changes, and moved IRep…
gregschohn 723bf77
Bundle all of the offloader spans with the netty handler spans.
gregschohn 15a1705
Improve the tracing story for the capture proxy.
gregschohn 8a6f52a
Tracing change: Flatten the flush span and just record it as 'blocked'.
gregschohn c50e01d
Minor cleanup - stop setting the namespace or trying to change in a p…
gregschohn 17c517d
Start instrumenting the replayer with more contexts so that traces an…
gregschohn 6288844
Double down on using Context objects in lieu of String labels and fix…
gregschohn 09e849c
Merge branch 'FixKafkaResume' into OtelMetricsAndTraces
gregschohn 9cf2540
Merge branch 'main' into OtelMetricsAndTraces
gregschohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
WIP to play with OpenTelemetry metric instruments and tracer spans.
Most of this is just playing, but making the StreamManager implement AutoCloseable gives a place to end spans to show how long a serializer/connection factory was relevant for. Signed-off-by: Greg Schohn <[email protected]>
commit c026588ef5a9cb1bca3aaf302481bd41444a7041
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
...loader/src/main/java/org/opensearch/migrations/trafficcapture/StreamLifecycleManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
package org.opensearch.migrations.trafficcapture; | ||
|
||
import java.io.IOException; | ||
import java.util.concurrent.CompletableFuture; | ||
|
||
public interface StreamLifecycleManager<T> { | ||
public interface StreamLifecycleManager<T> extends AutoCloseable { | ||
CodedOutputStreamHolder createStream(); | ||
|
||
CompletableFuture<T> closeStream(CodedOutputStreamHolder outputStreamHolder, int index); | ||
void close() throws IOException; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference to local needs removal