Minor tag bug fix and README update for devDeploy #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
chelma,
gregschohn,
kartg,
mikaylathompson,
okhasawn and
sumobrian
as code owners
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
=========================================
Coverage 64.63% 64.63%
Complexity 804 804
=========================================
Files 94 94
Lines 3896 3896
Branches 326 326
=========================================
Hits 2518 2518
Misses 1171 1171
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. |
mikaylathompson
approved these changes
Sep 13, 2023
4 tasks
gregschohn
added a commit
to gregschohn/opensearch-migrations
that referenced
this pull request
Sep 15, 2023
…yLeakFix * main: Two bugfixes to facilitate "--remove-auth-headers" (MIGRATIONS-1309). First, wire up the remove method for the wrapper (list adapting) map of the case insensitive map implementation so that remove() is actually called on the underlying map, rather than calling an UnsupportedOperationException. The second issue was that the original request headers and the newly transformed headers were deemed to be identical, even though an item was missing within the transformed map. We only iterated through the transformed map and we didn't make sure that we were going to hit all of the elements. Now we check that the lengths are the same too. Minor tag bug fix and README update for devDeploy (opensearch-project#318) Signed-off-by: Greg Schohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
None
Testing
Manual deployment testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.